Skip to content

Set packageName in TypeScript reference file#5827

Closed
devloco wants to merge 9 commits into
react:masterfrom
devloco:set-packageName-in-TypeScript-reference-file
Closed

Set packageName in TypeScript reference file#5827
devloco wants to merge 9 commits into
react:masterfrom
devloco:set-packageName-in-TypeScript-reference-file

Conversation

@devloco
Copy link
Copy Markdown

@devloco devloco commented Nov 16, 2018 •
edited
Loading

This PR is sent as suggested by @Timer here:
#5811

Here are the full steps that I used to test:

  1. I published my react-scripts changes to NPM as @devloco/react-scripts-test
  2. bash prompt at: create-react-app/packages/create-react-app
  3. npm link (to pick up the changes made to createReactApp.js)
  4. cd ~/temp
  5. create-react-app foo1 --typescript --scripts-version @devloco/react-scripts-test
  6. See app creation succeed.
  7. cd foo1/src
  8. vim react-app-env.d.ts
  9. See that "types" prop value is @devloco/react-scripts-test
  10. :q! + ENTER to exit vim
  11. yarn start
  12. See no errors happen. Webpack Dev Server and browser tab launch successfully. Page renders in browser as usual.

Screenshots:
pr1
pr2
pr3

Make sure that not using --scripts-version still works the same

  1. cd ~/temp
  2. `create-react-app foo2 --typescript
  3. See app creation succeed.
  4. cd foo2/src
  5. vim react-app-env.d.ts
  6. See that "types" prop value is react-scripts
  7. :q! + ENTER to exit vim
  8. yarn start
  9. See no errors happen. Webpack Dev Server and browser tab launch successfully. Page renders in browser as usual.

@devloco
Merge pull request #1 from facebook/master
9cc88c1 
Update from upstream repo facebook/create-react-app@master
@devloco
Merge pull request #2 from facebook/master
f17ddd4 
Update from upstream repo facebook/create-react-app@master
@devloco
Merge pull request #3 from facebook/master
3ff8802 
Update from upstream repo facebook/create-react-app@master
@devloco
Merge pull request #4 from facebook/master
df5849b 
Update from upstream repo facebook/create-react-app@master
@devloco
Merge pull request #5 from facebook/master
10ca548 
Update from upstream repo facebook/create-react-app@master
@devloco
Merge pull request #6 from facebook/master
539b59a 
Update from upstream repo facebook/create-react-app@master
@devloco
Merge pull request #7 from facebook/master
72389d8 
Update from upstream repo facebook/create-react-app@master
@devloco
Merge pull request #8 from facebook/master
c4fa56e 
Update from upstream repo facebook/create-react-app@master
@devloco
set packageName for TypeScript ref
dec3d63
@facebook-github-bot
Copy link
Copy Markdown

facebook-github-bot commented Nov 16, 2018

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown

facebook-github-bot commented Nov 16, 2018

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer
Copy link
Copy Markdown
Contributor

Timer commented Nov 20, 2018

Hmm, this would break existing apps adding TypeScript. We just need to parse it from paths.ownPackageJson.

@Timer Timer mentioned this pull request Nov 22, 2018
Closed
@mrmckeb
Copy link
Copy Markdown
Contributor

mrmckeb commented Dec 3, 2018

@Timer This is included in this #5877, along with another fix.

@devloco devloco closed this Dec 8, 2018
@devloco devloco deleted the set-packageName-in-TypeScript-reference-file branch December 8, 2018 17:02
@jimthedev jimthedev mentioned this pull request Dec 18, 2018
Open
@lock lock Bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devloco @facebook-github-bot @Timer @mrmckeb